[ET-VK] Adding source_offset processing to copy_packed_dim_offset function. #9344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction. This diff change `copy_packed_dim_offset` function and associated shader to handle the source_offset parameter. This change will help enable all tensor packing for slice op. Differential Revision: [D71349217](https://our.internmc.facebook.com/intern/diff/D71349217/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9344
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 2d121bf with merge base 1ccc5a0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71349217 |
yipjustin
approved these changes
Mar 19, 2025
…_offset function." This diff change `copy_packed_dim_offset` function and associated shader to handle the source_offset parameter. This change will help enable all tensor packing for slice op. Differential Revision: [D71349217](https://our.internmc.facebook.com/intern/diff/D71349217/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D71349217 |
facebook-github-bot
merged commit 8a92d80
into
gh/trivedivivek/65/base
81 of 83 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
Mar 20, 2025
…ction. (#9438) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9344 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/65/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/65/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/64/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/65/orig @diff-train-skip-merge Co-authored-by: Vivek Trivedi <[email protected]>
kirklandsign
pushed a commit
that referenced
this pull request
Mar 20, 2025
…ction. (#9438) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9344 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/65/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/65/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/64/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/65/orig @diff-train-skip-merge Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff change
copy_packed_dim_offsetfunction and associated shader to handle the source_offset parameter.This change will help enable all tensor packing for slice op.
Differential Revision: D71349217